Moti Asayag has posted comments on this change.
Change subject: core: adding containers to store VM device data mapping for
import and export
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
Line 1641: public void setManagedDeviceMap(Map<Guid, VmDevice> map) {
if vmStatic could be null, same check should be made in the setters.
Line 1653: mVmStatic.setUnmanagedDeviceList(list);
same here, access to vmStatic should be null safe
--
To view, visit http://gerrit.ovirt.org/2711
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I178bc1d54619ef5e908f46e4cd7fd67eb59ccb19
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
