Moti Asayag has posted comments on this change.
Change subject: core: adding containers to store VM device data mapping for
import and export
......................................................................
Patch Set 2: Looks good to me, approved
Please add another patch to replace the null checks in the getters/setters with
initialization of the VmStatic and VmDynamic in case those were provided null
to the VM c'tor:
public VM(VmStatic vmStatic, VmDynamic vmDynamic, VmStatistics vmStatistics){
...
mVmStatic = vmStatic == null ? new VmStatic() : vmStatic;
mVmDynamic = vmDynamic == null ? new VmDynamic() : vmDynamic;
...
}
--
To view, visit http://gerrit.ovirt.org/2711
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I178bc1d54619ef5e908f46e4cd7fd67eb59ccb19
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
