Yair Zaslavsky has posted comments on this change.
Change subject: DO NOT SUBMIT core: Introducing AddVmFromSnapshot command
......................................................................
Patch Set 23: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java
Line 67: public NGuid getStorageDomainId() {
Agreed, I will keep this cached, although from debugging I see we call it only
during logging time.
Line 69: List<DiskImage> images =
getDiskImageDao().getAllSnapshotsForVmSnapshot(sourceSnapshotId);
In general, this method is required for logging purposes only.
IMHO,We should revisit this , not just for this command, but for all commands
that use multiple storage domains.
Line 112: diskImage,
What do you think should be the source storage domain for
MoveOrCopyImageGroupCommand? (I'm referring to
MoveOrCopyImageGroupParameters.sourceDomainId )
?
Line 375:
Well, I can change it to check on getSnapshot and save like this a redundant
call to Db.
--
To view, visit http://gerrit.ovirt.org/2300
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ac7e0c801faf6bca9932c5ed47dc6a065c1ac51
Gerrit-PatchSet: 23
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
