Mike Kolesnik has posted comments on this change. Change subject: DO NOT SUBMIT core: Introducing AddVmFromSnapshot command ......................................................................
Patch Set 30: Looks good to me, approved (2 inline comments) Since yzas fixed it already in newer code .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java Line 299: }); You should freeLock after the transaction is committed. Line 351: freeLock(); This should go -- To view, visit http://gerrit.ovirt.org/2300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ac7e0c801faf6bca9932c5ed47dc6a065c1ac51 Gerrit-PatchSet: 30 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
