Mike Kolesnik has posted comments on this change.
Change subject: DO NOT SUBMIT core: Introducing changes to commands hierarchy
......................................................................
Patch Set 27: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotCommand.java
Line 156: protected void processOldDbImages() {
minor: It is actually just for single image, so no need to call it images.
I wouldn't change the name in this patch anyway since it's unrelated..
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateSnapshotFromTemplateParameters.java
Line 5: public class CreateSnapshotFromTemplateParameters extends
ImagesActionsParametersBase implements java.io.Serializable {
minor: No need to implement Serializable it's already part of the heirarchy..
--
To view, visit http://gerrit.ovirt.org/2299
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7f4abd569a8a620ca9657d4c472bb7b59a57429
Gerrit-PatchSet: 27
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
