Mike Kolesnik has posted comments on this change. Change subject: DO NOT SUBMIT core: Introducing changes to commands hierarchy ......................................................................
Patch Set 30: (1 inline comment) Basically +2 but some minor comments on this set and set 27 (which you might've missed) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java Line 73: DiskImage diskImage = getDiskImageToRemoveByParam((MoveOrCopyImageGroupParameters) param); minor: You can cast the whole list.. Also no need to keep a reference to ArrayList.. -- To view, visit http://gerrit.ovirt.org/2299 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7f4abd569a8a620ca9657d4c472bb7b59a57429 Gerrit-PatchSet: 30 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
