Allon Mureinik has posted comments on this change. Change subject: engine: Refactor quota general limitations ......................................................................
Patch Set 2: Looks good to me, but someone else must approve (4 inline comments) basically like this change - see some inline comments. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QuotaHelper.java Line 245: List<QuotaStorage> quotaStorageList = quota.getQuotaStorages(); I'd wrap "quota.getGlobalQuotaStorage() != null" in a utility method - e.g., isGlobal(Quota) .................................................... File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/QuotaHelperTest.java Line 125: Assert.assertEquals(QuotaHelper.UNLIMITED, quotaUnlimited.getGlobalQuotaStorage().getStorageSizeGB()); Use assertEquals instead of assertTrue. Also, I'd statically import all of needed methods from Assert, but that's a matter of taste. Line 237: Assert.assertEquals(QuotaHelper.UNLIMITED, quotaUnlimited.getGlobalQuotaStorage().getStorageSizeGB()); same as above. Line 248: Assert.assertEquals(QuotaHelper.UNLIMITED, quotaUnlimited.getGlobalQuotaStorage().getStorageSizeGB()); same as above. -- To view, visit http://gerrit.ovirt.org/3087 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8cef38c35154c17d7f35e6a0dea80706db7fa9b0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
