Maor Lipchuk has posted comments on this change. Change subject: engine: Refactor quota general limitations ......................................................................
Patch Set 2: (2 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QuotaHelper.java Line 245: List<QuotaStorage> quotaStorageList = quota.getQuotaStorages(); Yes, it makes sense, I actually think it would be more efficient to add it to the Quota BE instead. .................................................... File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/QuotaHelperTest.java Line 125: Assert.assertEquals(QuotaHelper.UNLIMITED, quotaUnlimited.getGlobalQuotaStorage().getStorageSizeGB()); Will be changed in next patch, regarding all comments -- To view, visit http://gerrit.ovirt.org/3087 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8cef38c35154c17d7f35e6a0dea80706db7fa9b0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
