Michael Pasternak has posted comments on this change.
Change subject: REST: add vm_network and bridged propertes
......................................................................
Patch Set 17: (8 inline comments)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 239:
WS
Line 241:
please use collection/resource pattern instead, see CPUs/CPU models as
i've suggested.
Line 244: <xs:enumeration value="vm_network" />
shouldn't it be just VM?
Line 245: <xs:enumeration value="display" />
no enumeration should be done in xsd, please
do it as we discussed on irc
Line 248:
WS
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
Line 656: optionalArguments: {network.display: 'xs:boolean',
network.usages: 'xs:usages'}
1. type should be collection of strings
2. what about adding this param to ADD?
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostNicMapper.java
Line 130: model.setBridged(entity.isBridged());
it suppose to change according to usages, right?
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkMapper.java
Line 59:
entity.setis_display(model.getUsages().contains(Usage.DISPLAY));
should be done via mapper of string->enum
--
To view, visit http://gerrit.ovirt.org/2479
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I92203cba0dd7a02ccc9dfc87d0a3f714d37733b6
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: [email protected]
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
