Roy Golan has posted comments on this change. Change subject: REST: add vm_network and bridged propertes ......................................................................
Patch Set 17: (2 inline comments) .................................................... File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostNicMapper.java Line 130: model.setBridged(entity.isBridged()); I think your confusing the Network property and the HostNic property . Future host_nic can be of type vNic which means its not bridged but is implementing a VM_NETWORK .................................................... File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkMapper.java Line 59: entity.setis_display(model.getUsages().contains(Usage.DISPLAY)); can you specify here why we cant use enums? (i didn't get to the bottom of your mind on IRC) -- To view, visit http://gerrit.ovirt.org/2479 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I92203cba0dd7a02ccc9dfc87d0a3f714d37733b6 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
