Moti Asayag has posted comments on this change. Change subject: core : Using count for updated rows ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (2 inline comments) .................................................... File backend/manager/dbscripts/async_tasks_sp.sql Line 45: RETURNS integer please delete white space .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/SimpleJdbcCallsHandler.java Line 19: private static final String RESULT_SET = "#result-set-1"; according to the documentation any undefined result set might get name as #result-set-1, #result-set-2,... This seems a bit risky and requires strict handle. See line 1028: http://grepcode.com/file/repo1.maven.org/maven2/org.springframework/spring/2.5.6/org/springframework/jdbc/core/JdbcTemplate.java -- To view, visit http://gerrit.ovirt.org/3383 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2509da57274c642e058baf7b5f45c7f43441e309 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
