Allon Mureinik has posted comments on this change. Change subject: core : Using count for updated rows ......................................................................
Patch Set 1: (2 inline comments) Love the idea, some implementation comments. .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/SimpleJdbcCallsHandler.java Line 43: If your psql function simply returns the rows effected, wht not use SimpleJDBCCAll.executeFunction instead of SimpleJDBCCAll.execute? .................................................... File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AsyncTaskDAOTest.java Line 127: consider testing with get()!=null too, so your test isn't completely dependent on remove() -- To view, visit http://gerrit.ovirt.org/3383 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2509da57274c642e058baf7b5f45c7f43441e309 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
