Daniel Erez has posted comments on this change.
Change subject: webadmin: Moved provider list initialization to NetworkModel
......................................................................
Patch Set 1:
(2 comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/EditNetworkModel.java
Line 79: @Override
Line 80: protected void selectExternalProvider() {
Line 81: Network network = getNetwork();
Line 82: if (network.isExternal()) {
Line 83: for (Provider provider : (Iterable<Provider>)
getExternalProviders().getItems()) {
use 'Linq.firstOrDefault' instead (i.e. using ProviderPredicate)
Line 84: if
(provider.getId().equals(network.getProvidedBy().getProviderId())) {
Line 85: getExternalProviders().setSelectedItem(provider);
Line 86: return;
Line 87: }
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java
Line 130: updateVlanTagChangeability();
Line 131: updateMtuChangeability();
Line 132: }
Line 133:
Line 134: private void initExternalProviderList() {
IIRC, NetworkModel might be use in other context (other than NIC popup). If so,
override Model's 'initialize' method and call it where relevant (the relevant
ListModel probably).
Line 135: startProgress(null);
Line 136: AsyncQuery getProvidersQuery = new AsyncQuery();
Line 137: getProvidersQuery.asyncCallback = new INewAsyncCallback() {
Line 138: @Override
--
To view, visit http://gerrit.ovirt.org/19110
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0856a02c14eafe1fe9b1867df1a3e9ef4d7e20d4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
