Daniel Erez has posted comments on this change.
Change subject: webadmin: Moved provider list initialization to NetworkModel
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java
Line 130: updateVlanTagChangeability();
Line 131: updateMtuChangeability();
Line 132: }
Line 133:
Line 134: private void initExternalProviderList() {
If your'e sure that the initialization is needed every time you create the
NetworkModel then it's fine. Just note that there's an 'initialize' method in
Model class that you can override (which is useful for situations that you need
a lazy initialization rather than in the ctr). Just make sure the the
NetworkModel isn't used as a 'stub- class' somewhere - i.e. the initialization
might be totally redundant.
Line 135: startProgress(null);
Line 136: AsyncQuery getProvidersQuery = new AsyncQuery();
Line 137: getProvidersQuery.asyncCallback = new INewAsyncCallback() {
Line 138: @Override
--
To view, visit http://gerrit.ovirt.org/19110
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0856a02c14eafe1fe9b1867df1a3e9ef4d7e20d4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
