Alexander Wels has posted comments on this change. Change subject: webadmin: CPU pinning disappearing ......................................................................
Patch Set 1: Tomas, Somewhere between where the original assignment is and where I put the new assignment. There is a piece of code that SOMETIMES changes the value. I could run the same code path several times and it worked, then the next time it would wipe out the value of the cpu pinning. By moving it the code that runs that wipes out the value is irrelevant, as the value is correctly set at the end of the method. I think 'updateHostPinning(vm.getMigrationSupport()) on line 237 is the culprit, due to the fact that if I don't mark the VM as tied to a particular host, the issue does not occur. -- To view, visit http://gerrit.ovirt.org/19707 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c87f65b2fc2d7434e6785291bd73fee15539faa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
