Tomas Jelinek has posted comments on this change.
Change subject: webadmin: CPU pinning disappearing
......................................................................
Patch Set 1: Code-Review+2
Well, I was asking because this seems as an issue with some callbacks not yet
returned but already used. So it may be that your fix fixes only the
consequence and not the problem.
So I have looked more close and I would say the path is like this:
updateHostPinning ->
getMigrationMode().setSelectedItem ->
UnitVmModel.eventRaised calls VmModelBehaviorBase.updateCpuPinningVisibility ->
if (!hasCpuPinning) {... getModel().getCpuPinning().setEntity("");
...
And that !hasCpuPinning depends (besides other things) on the
getModel().getMigrationMode which is indeed set after the
getModel().getCpuPinning().setEntity(vm.getCpuPinning()) - e.g. the value there
is more or less random.
So long story short, your fix seems to be correct :)
Next time please provide an exact reason what was wrong and how your fix is
solving the issue - I don't dare to give +2 if I don't understand how the fix
is supposed to help. This time I have looked it up by myself...
--
To view, visit http://gerrit.ovirt.org/19707
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c87f65b2fc2d7434e6785291bd73fee15539faa
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
