Martin Peřina has posted comments on this change. Change subject: core: Adds missing 3rd party dependencies as modules ......................................................................
Patch Set 2: (1 comment) .................................................... File ear/src/main/resources/META-INF/MANIFEST.MF Now I probably understand what you mean. Since these 3 new modules are 2nd level dependencies, they should not be contained in MANIFEST.MF, since they will be loaded by 1st level dependencies (for example xz will be loaded by commons-compress), right? If so, I will remove them in next patch set Line 1: Manifest-Version: 1.0 Line 2: Dependencies: asm.asm, Line 3: javax.validation.api, Line 4: org.aopalliance, -- To view, visit http://gerrit.ovirt.org/20048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35cc0d983010b4e0ab7ca4cea15a80a051fe9254 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
