Martin Peřina has posted comments on this change. Change subject: core: Adds missing 3rd party dependencies as modules ......................................................................
Patch Set 2: (2 comments) .................................................... File backend/manager/dependencies/src/main/modules/com/mchange/c3p0/main/module.xml Line 6: <resource-root path="c3p0.jar"/> Line 7: </resources> Line 8: Line 9: <dependencies> Line 10: <module name="javax.api"/> Sorry, I forgot to answer this: I looked at c3p0 package and strange thing is, that c3p0 RPM doesn't have this dependency on slf4j and also this dependency is not contained in MANIFEST.MF of c3p0.jar. But since we are doing this cleanup, you are right, we should add this dependency to module also. I will do this ASAP. Line 11: </dependencies> Line 12: .................................................... File ear/src/main/resources/META-INF/MANIFEST.MF Maybe Juan will be able to answer this, I added missing deps here, because others were also included here Line 1: Manifest-Version: 1.0 Line 2: Dependencies: asm.asm, Line 3: javax.validation.api, Line 4: org.aopalliance, -- To view, visit http://gerrit.ovirt.org/20048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35cc0d983010b4e0ab7ca4cea15a80a051fe9254 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
