Liron Ar has posted comments on this change.
Change subject: core: Remove unexisting Storage Domain will be roll forward.
......................................................................
Patch Set 3:
(4 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommand.java
Line 184: DetachStorageDomainFromPoolParameters params = new
DetachStorageDomainFromPoolParameters(domId, poolId);
Line 185: params.setDestroyingPool(getParameters().getDestroyingPool());
Line 186:
Line 187: return getBackend()
Line 188:
.runInternalAction(VdcActionType.DetachStorageDomainFromPool,
general - cant we get the same error here?
Line 189: params).getSucceeded();
Line 190: }
Line 191:
Line 192: protected boolean formatStorage(StorageDomain dom, VDS vds) {
Line 194: return getVdsBroker()
Line 195: .RunVdsCommand(VDSCommandType.FormatStorageDomain,
Line 196: new
FormatStorageDomainVDSCommandParameters(vds.getId(),
dom.getId())).getSucceeded();
Line 197: } catch (VdcBLLException e) {
Line 198: if (e.getVdsError().getCode() !=
VdcBllErrors.StorageDomainDoesNotExist) {
1. please replace getVdsError().getCode() with getErrorCode().
2. please consider to change to VdcBllErrors.StorageDomainDoesNotExist.equals..
Line 199: throw e;
Line 200: }
Line 201: log.warnFormat("Storage Domain {0} which was about to be
formatted was not exists in VDS id {1}",
Line 202: vds.getId(),
Line 197: } catch (VdcBLLException e) {
Line 198: if (e.getVdsError().getCode() !=
VdcBllErrors.StorageDomainDoesNotExist) {
Line 199: throw e;
Line 200: }
Line 201: log.warnFormat("Storage Domain {0} which was about to be
formatted was not exists in VDS id {1}",
please fix the message
Line 202: vds.getId(),
Line 203: dom.getId());
Line 204: return true;
Line 205: }
Line 199: throw e;
Line 200: }
Line 201: log.warnFormat("Storage Domain {0} which was about to be
formatted was not exists in VDS id {1}",
Line 202: vds.getId(),
Line 203: dom.getId());
1. the parameters are in wrong order
2. please add vds/domain names.
Line 204: return true;
Line 205: }
Line 206: }
Line 207:
--
To view, visit http://gerrit.ovirt.org/20158
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9515a5ddfcaa965c2bad1883f0543494915b8c7d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
