Maor Lipchuk has posted comments on this change. Change subject: core: Remove unexisting Storage Domain will be rolled forward. ......................................................................
Patch Set 4: (2 comments) .................................................... Commit Message Line 3: AuthorDate: 2013-10-14 16:13:15 +0300 Line 4: Commit: Maor Lipchuk <[email protected]> Line 5: CommitDate: 2013-10-14 19:01:15 +0300 Line 6: Line 7: core: Remove unexisting Storage Domain will be rolled forward. done. Line 8: Line 9: Removal of a Storage Domain which no longer exists causes a failure in Line 10: the engine and blocks the user from removing the storage. Line 11: .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommand.java Line 199: throw e; Line 200: } Line 201: log.warnFormat("Storage Domain {0} which was about to be formatted does not exist in VDS {1}", Line 202: dom.getName(), Line 203: vds.getName()); I disagree, IMHO it is not that crucial, this is only a warning log and not a UI message which the user has to make conclusions from. The purpose of this log is to give the programmer the information what have happened during the flow (It is not an error). It could be ids and it could be names, it is not that necessary to put both of them. Line 204: return true; Line 205: } Line 206: } Line 207: -- To view, visit http://gerrit.ovirt.org/20158 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9515a5ddfcaa965c2bad1883f0543494915b8c7d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
