Michael Pasternak has posted comments on this change.
Change subject: core, restapi: Introducing support for attaching disk snapshot
......................................................................
Patch Set 33:
(2 comments)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
Line 552: disk.sgio: xs:string
Line 553: disk.storage_domains.storage_domain--COLLECTION:
{storage_domain.id|name: 'xs:string'}
Line 554: description: add a new direct lun disk to the virtual
machine, this operation does not require size but needs lun connection details
Line 555: - mandatoryArguments: {disk.id: 'xs:string'}
Line 556: optionalArguments: {disk.active: 'xs:boolean',
disk.snapshot.id: xs:string}
please remove ", disk.snapshot.id: xs:string" - it has own signature now
Line 557: description: attach a disk to the virtual machine
Line 558: - mandatoryArguments: {disk.id: 'xs:string', disk.snapshot.id:
xs:string}
Line 559: optionalArguments: {disk.active: 'xs:boolean'}
Line 560: description: attach a disk snapshot to the virtual machine
....................................................
File
backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/DiskMapperTest.java
Line 34: assertEquals(model.getImageId(), transform.getImageId());
Line 35: assertEquals(model.getFormat(), transform.getFormat());
Line 36: assertEquals(model.getInterface(), transform.getInterface());
Line 37: assertEquals(model.isActive(), transform.isActive());
Line 38: assertEquals(model.getSnapshot().getId(),
transform.getSnapshot().getId());
i'd add assertNonNull(model.getSnapshot()) before this line
Line 39: assertEquals("unexpected status",
model.getStatus().getState(), transform.getStatus().getState());
Line 40: assertEquals("unexpected sparse", model.isSparse(),
transform.isSparse());
Line 41: assertEquals("unexpected bootable", model.isBootable(),
transform.isBootable());
Line 42: assertEquals("unexpected propagate errors",
model.isPropagateErrors(), transform.isPropagateErrors());
--
To view, visit http://gerrit.ovirt.org/17679
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02579bf1a91cd294a5040acf432f1fdb87eb18c1
Gerrit-PatchSet: 33
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
