Liron Ar has posted comments on this change.
Change subject: core, restapi: Introducing support for attaching disk snapshot
......................................................................
Patch Set 34:
(1 comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java
Line 219: // order first by drive numbers and then order by boot for
the bootable
Line 220: // drive to be first (important for IDE to be index 0) !
Line 221: List<Disk> diskImages = new ArrayList<Disk>(vm.getDiskMap()
Line 222: .values());
Line 223: List<Pair<Disk, VmDevice>> toReturn = new ArrayList<>();
Actually this list is mandatory here and should be returned with disk/vm
device, the sorting should be done by the boot order there otherwise the disks
won't return in the correct boot order. I don't know how this code got lost in
the way and older code went it - probably a lost local commit by mistake. I
abandoned the patch and will reapply the changes and will upload it again.
Line 224: Collections.sort(diskImages, new
DiskImageByDiskAliasComparator());
Line 225: Collections.sort(diskImages,
Line 226: Collections.reverseOrder(new
DiskImageByBootComparator()));
Line 227: Collections.sort(diskImages, new Comparator<Disk>() {
--
To view, visit http://gerrit.ovirt.org/17679
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02579bf1a91cd294a5040acf432f1fdb87eb18c1
Gerrit-PatchSet: 34
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
