Kanagaraj M has posted comments on this change.
Change subject: webadmin : gluster volume rebalance status error handling
......................................................................
Patch Set 12:
(3 comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java
Line 584: public void onSuccess(Object model, Object returnValue) {
Line 585: cModel.stopProgress();
Line 586: GlusterVolumeTaskStatusEntity rebalanceStatusEntity =
Line 587: (GlusterVolumeTaskStatusEntity)
((VdcQueryReturnValue) returnValue).getReturnValue();
Line 588: if ((!((VdcQueryReturnValue)
returnValue).getSucceeded()) || (rebalanceStatusEntity == null)) {
you could extract returnValue to a local variable so you could limit to one
type case
Line 589: cModel.setMessage(ConstantsManager.getInstance()
Line 590: .getMessages()
Line 591:
.rebalanceStatusConfirmationMessage(volumeEntity.getName()));
Line 592: } else {
Line 611:
Line 612:
stopRebalanceFromStatus.setTitle(ConstantsManager.getInstance()
Line 613: .getConstants()
Line 614: .stopRebalance());
Line 615:
Why the title is being set twice?
Line 616:
rebalanceStatusModel.getCommands().add(stopRebalanceFromStatus);
Line 617:
Line 618:
stopRebalanceFromStatus.setIsExecutionAllowed(rebalanceStatusEntity.getStatusSummary()
Line 619: .getStatus() ==
JobExecutionStatus.STARTED);
....................................................
File
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
Line 297: @DefaultMessage("{0} ({1} Socket(s), {2} Core(s) per Socket)")
Line 298: String cpuInfoMessage(int numOfCpus, int sockets, int
coresPerSocket);
Line 299:
Line 300: @DefaultMessage("Could not fetch rebalance status of volume :
{0}")
Line 301: String rebalanceStatusConfirmationMessage(String name);
this method can be better called as "rebalanceStatusFailed(...)"
Line 302:
Line 303: @DefaultMessage("The following disks cannot be moved: {0}")
Line 304: String cannotMoveDisks(String disks);
Line 305:
--
To view, visit http://gerrit.ovirt.org/19598
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie13748716f23a797fc0e3ec16acbb4150c43b7e8
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: anmolbabu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
