Allon Mureinik has posted comments on this change.
Change subject: core: [DO NOT SUBMIT] Default quota name
......................................................................
Patch Set 3: (3 inline comments)
....................................................
File backend/manager/dbscripts/upgrade/03_01_0910_fix_default_quota_name.sql
Line 2: SET quota_name = 'DefaultQuota-' || (SELECT name FROM storage_pool
WHERE storage_pool.id = quota.storage_pool_id)
Done
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QuotaHelper.java
Line 377: if (!quota.getIsDefaultQuota() &&
quota.getQuotaName().equals(defaultQuotaForDCName)) {
This was not done previously - see, e.g., checkQuotaNameExisting()
Line 389: protected String getStoragePoolNameForQuota(Quota quota) {
Nice catch!
Let's do something simple here - if it isn't a default quota, it's name can't
start 'DefaultQuota-"
--
To view, visit http://gerrit.ovirt.org/3673
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c58f42a28a21ebe4fdacf09647fe085327b6437
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
