Maor Lipchuk has posted comments on this change.
Change subject: core: [DO NOT SUBMIT] Default quota name
......................................................................
Patch Set 7: Looks good to me, approved
(2 inline comments)
Looks good, minor comments inline.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QuotaHelper.java
Line 248: // In add - the default quota is generated by the command, so
no validation is done
Consider rephrasing the comment, I didn't understand why no validation is done
when adding a quota (Perhaps you meant only for the default quota)
Line 377: public boolean checkQuotaNameReserved(Quota quota, List<String>
messages) {
Consider adding a java doc comment which reflects the check of the method
(Could be helpful since only the prefix is being checked)
--
To view, visit http://gerrit.ovirt.org/3673
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c58f42a28a21ebe4fdacf09647fe085327b6437
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
