Maor Lipchuk has posted comments on this change.
Change subject: core, restapi: Introducing support for attaching disk snapshot
......................................................................
Patch Set 37: Code-Review+1
(2 comments)
Looks good, please address minor comments inside
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java
Line 118: _vdsGroupIds = new ArrayList<Guid>();
Line 119: Set<Guid> vdsWithRunningVMs = new HashSet<Guid>();
Line 120: List<String> hostNotRespondingList = new ArrayList<String>();
Line 121: List<String> hostsWithNonMigratableVms = new
ArrayList<String>();
Line 122: List<String> hostsWithVmsWithPluggedDiskSnapshots = new
ArrayList<String>();
You can use diamond here
Line 123: List<String> nonMigratableVms = new ArrayList<String>();
Line 124:
Line 125: for (Guid vdsId : getParameters().getVdsIdList()) {
Line 126: VDS vds = DbFacade.getInstance().getVdsDao().get(vdsId);
Line 325:
Line 326: private void
handleHostsWithVmsWithPluggedDiskSnapshots(List<String>
hostsWithVmsWithPluggedDiskSnapshots) {
Line 327: if (!hostsWithVmsWithPluggedDiskSnapshots.isEmpty()) {
Line 328:
getReturnValue().getCanDoActionMessages().add((String.format("$HostsList %1$s",
Line 329:
StringUtils.join(hostsWithVmsWithPluggedDiskSnapshots, " , "))));
/s/" , "/", " or "," (without white spaces) - All of our storage CDA messages
which use StringUtils.join has this format when initializing a CDA message, I
think it will be better if the format will be unified.
Line 330: }
Line 331: }
Line 332:
Line 333: private void addClusterDetails(Guid vdsGroupID, List<String>
clustersWithRunningVms) {
--
To view, visit http://gerrit.ovirt.org/17679
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02579bf1a91cd294a5040acf432f1fdb87eb18c1
Gerrit-PatchSet: 37
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
