Daniel Erez has posted comments on this change.
Change subject: core, restapi: Introducing support for attaching disk snapshot
......................................................................
Patch Set 39: Code-Review+1
(2 comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java
Line 446: AbstractDiskModel diskModel = (AbstractDiskModel)
target;
Line 447: ArrayList<Disk> disks = (ArrayList<Disk>) returnValue;
Line 448:
Line 449: diskModel.getIsBootable().setEntity(true);
Line 450: if (getDisk() == null || !getDisk().isDiskSnapshot())
{
better to avoid this if getDisk() is null. I.e. consider changing to something
like: 'getDisk() != null && !getDisk().isDiskSnapshot()'. Or, just early return
when 'getDisk() == null || getDisk.isDiskSnapshot()'
Line 451: for (Disk disk : disks) {
Line 452: if (disk.isBoot() && !disk.equals(getDisk()))
{
Line 453:
diskModel.getIsBootable().setEntity(false);
Line 454: if (!disk.isDiskSnapshot()) {
Line 456:
diskModel.getIsBootable().setIsChangable(false);
Line 457: break;
Line 458: }
Line 459: }
Line 460: }
formatter
Line 461: }
Line 462:
Line 463: if (!getIsNew()) {
Line 464: getIsBootable().setEntity(getDisk().isBoot());
--
To view, visit http://gerrit.ovirt.org/17679
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02579bf1a91cd294a5040acf432f1fdb87eb18c1
Gerrit-PatchSet: 39
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Eyal Edri <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
