Daniel Erez has uploaded a new change for review. Change subject: webadmin: image cell - show tooltip only when needed ......................................................................
webadmin: image cell - show tooltip only when needed StyledImageResourceCell -> title panel should be visible only when a title is available (i.e. != empty string). Example screenshot: http://i.imgur.com/oem3uNH.png Change-Id: If3ea9edf883dfffe59996ef31efe96a6d60f6ccf Signed-off-by: Daniel Erez <[email protected]> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/StyledImageResourceCell.java 1 file changed, 9 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/26/20426/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/StyledImageResourceCell.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/StyledImageResourceCell.java index ae65028..7059cb5 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/StyledImageResourceCell.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/StyledImageResourceCell.java @@ -81,10 +81,17 @@ @Override public void onBrowserEvent(Context context, Element parent, ImageResource value, NativeEvent event, ValueUpdater<ImageResource> valueUpdater) { + String eventType = event.getType(); + handleTitlePanel(eventType, parent); + } + + private void handleTitlePanel(String eventType, Element parent) { + if (title == "") { //$NON-NLS-1$ + // no need to show/hide title + return; + } titlePanel.setWidget(new Label(title)); - String eventType = event.getType(); - if (BrowserEvents.MOUSEOVER.equals(eventType)) { titlePanel.showRelativeTo(parent); } -- To view, visit http://gerrit.ovirt.org/20426 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If3ea9edf883dfffe59996ef31efe96a6d60f6ccf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
