Vojtech Szocs has posted comments on this change.
Change subject: webadmin: image cell - show tooltip only when needed
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/StyledImageResourceCell.java
Line 85: handleTitlePanel(eventType, parent);
Line 86: }
Line 87:
Line 88: private void handleTitlePanel(String eventType, Element parent) {
Line 89: if (title == "") { //$NON-NLS-1$
Just a small thing, I'd rather do
if (title.isEmpty()) ...
or alternatively
if ("".equals(title)) ...
but I guess it's the same thing in the end, from generated JavaScript
perspective.
Line 90: // no need to show/hide title
Line 91: return;
Line 92: }
Line 93:
--
To view, visit http://gerrit.ovirt.org/20426
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3ea9edf883dfffe59996ef31efe96a6d60f6ccf
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
