Maor Lipchuk has posted comments on this change.
Change subject: core, restapi: Introducing support for attaching disk snapshot
......................................................................
Patch Set 43:
(3 comments)
Please see minor comments inside (specially at VmDAO)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java
Line 205: getLockManager().acquireLockWait(snapshotsEngineLock);
Line 206: }
Line 207:
Line 208: /**
Line 209: * this method returns the vm that a non shareable disk active
snapshot is attached to
/s/non shareable disk active snapshot/non shareable disk or an active disk/
Line 210: * or null is the disk is unattached to any vm,
Line 211: * @param disk
Line 212: * @return
Line 213: */
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java
Line 371:
!validate(storageValidator.allDomainsWithinThresholds()) ||
Line 372: !performImagesChecks() ||
Line 373: !validate(vmValidator.vmDown()) ||
Line 374: // if the user choose to commit a snapshot - the vm
cant have disk snapshots attached to other vms.
Line 375: (targetSnapshot.getType() == SnapshotType.REGULAR &&
!validate(vmValidator.vmNotHavingDeviceSnapshotsAttachedToOtherVms()))) {
please consider to re-extract in later patch
Line 376: return false;
Line 377: }
Line 378:
Line 379: Snapshot snapshot =
getSnapshotDao().get(getParameters().getDstSnapshotId());
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAO.java
Line 70: /**
Line 71: * Retrieves a list of VMs for the specified disk id.
Line 72: *
Line 73: *
Line 74: * @param includeVmsSnapshotAttachedTo@return A {@link List} of
the VMs associated with the disk.
This is not the right format (@return blends with the param name) also you
removed the id, please fix it
Line 75: */
Line 76: List<VM> getVmsListForDisk(Guid id, boolean
includeVmsSnapshotAttachedTo);
Line 77:
Line 78: /**
--
To view, visit http://gerrit.ovirt.org/17679
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02579bf1a91cd294a5040acf432f1fdb87eb18c1
Gerrit-PatchSet: 43
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Eyal Edri <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
