Alon Bar-Lev has posted comments on this change.
Change subject: engine : Remove GetAllServerCpuListParameters class
......................................................................
Patch Set 2:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllServerCpuListQuery.java
Line 57: }
Line 58:
Line 59: @Override
Line 60: protected void executeQueryCommand() {
Line 61:
getQueryReturnValue().setReturnValue(CpuFlagsManagerHandler.AllServerCpuList(getVersion()));
I expect a simple:
getQueryReturnValue().setReturnValue(
CpuFlagsManagerHandler.AllServerCpuList(
getParameters().getParameterValue<Version>(VdcParameter.Version)
)
)
Line 62: }
Line 63:
Line 64: private Version getVersion() {
Line 65: return (Version)
getParameters().getParameterValue(VdcParameter.Version);
Line 61:
getQueryReturnValue().setReturnValue(CpuFlagsManagerHandler.AllServerCpuList(getVersion()));
Line 62: }
Line 63:
Line 64: private Version getVersion() {
Line 65: return (Version)
getParameters().getParameterValue(VdcParameter.Version);
no need for getter for each parameter.
Line 66: }
--
To view, visit http://gerrit.ovirt.org/20416
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifedb114e8a2294bb3868077c0d3466557b1b8d45
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
