Alon Bar-Lev has posted comments on this change.
Change subject: engine : Remove GetAllServerCpuListParameters class
......................................................................
Patch Set 2:
(2 comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
Line 1722: };
Line 1723: Frontend.RunQuery(VdcQueryType.GetAllServerCpuList,
getAllServerCpuListParameters(version), aQuery);
Line 1724: }
Line 1725:
Line 1726: private static VdcQueryParametersBase
getAllServerCpuListParameters(Version version) {
why do we need this function?
Line 1727: VdcQueryParametersBase params = new VdcQueryParametersBase();
Line 1728: try {
Line 1729: params.addParameter(VdcParameter.Version, version);
Line 1730: } catch (InvalidParameterValueException ex) {
Line 1727: VdcQueryParametersBase params = new VdcQueryParametersBase();
Line 1728: try {
Line 1729: params.addParameter(VdcParameter.Version, version);
Line 1730: } catch (InvalidParameterValueException ex) {
Line 1731: }
please do not ignore exception, maybe this exception should be runtime
exception as it is not something that is expected.
Line 1732: return params;
Line 1733: }
Line 1734:
Line 1735: public static void getPmTypeList(AsyncQuery aQuery, Version
version) {
--
To view, visit http://gerrit.ovirt.org/20416
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifedb114e8a2294bb3868077c0d3466557b1b8d45
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
