Sandro Bonazzola has posted comments on this change.

Change subject: core:  exportDbSchema scripts generates output...
......................................................................


Patch Set 1:

(1 comment)

....................................................
File packaging/dbscripts/exportDbSchema.sh
Line 17:     printf "\t-u USERNAME   - The username for the database            
(def. engine)\n"
Line 18:     printf "\t-l LOGFILE    - The logfile for capturing output         
(def. ${LOGFILE}\n"
Line 19:     printf "\t-v            - Turn on verbosity (WARNING: lots of 
output)\n"
Line 20:     printf "\t-h            - This help text.\n"
Line 21:     printf "\n"
I suggest also to add a -o switch for allowing to specify an output directory, 
otherwise the output will go in /usr/share/ovirt-engine/dbscripts which is not 
supposed to be filled at runtime.
Line 22:     popd>/dev/null
Line 23:     exit $ret
Line 24: }
Line 25: 


-- 
To view, visit http://gerrit.ovirt.org/19679
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3d05e96f4abc66e293db23af89285b0653025537
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Martin PeÅ™ina <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to