Eli Mesika has posted comments on this change.
Change subject: core: exportDbSchema scripts generates output...
......................................................................
Patch Set 1:
(5 comments)
....................................................
File packaging/dbscripts/exportDbSchema.sh
Line 5: source ./dbcustomfunctions.sh
Line 6:
Line 7: #setting defaults
Line 8: set_defaults
Line 9: VERBOSE=false
leaving as is
Line 10:
Line 11: usage() {
Line 12: printf "Usage: ${ME} [-h] [-s SERVERNAME] [-p PORT] [-d DATABASE]
[-u USERNAME] [-v]\n"
Line 13: printf "\n"
Line 8: set_defaults
Line 9: VERBOSE=false
Line 10:
Line 11: usage() {
Line 12: printf "Usage: ${ME} [-h] [-s SERVERNAME] [-p PORT] [-d DATABASE]
[-u USERNAME] [-v]\n"
ME is set to $0 by set_defaults
Formatting should be done in a separate patch , not related to this BZ
Line 13: printf "\n"
Line 14: printf "\t-s SERVERNAME - The database servername for the database
(def. ${SERVERNAME})\n"
Line 15: printf "\t-p PORT - The database servername port for the
database (def. ${PORT})\n"
Line 16: printf "\t-d DATABASE - The database name
(def. ${DATABASE})\n"
Line 17: printf "\t-u USERNAME - The username for the database
(def. engine)\n"
Line 18: printf "\t-l LOGFILE - The logfile for capturing output
(def. ${LOGFILE}\n"
Line 19: printf "\t-v - Turn on verbosity (WARNING: lots of
output)\n"
Line 20: printf "\t-h - This help text.\n"
Line 21: printf "\n"
should be done in a separate patch , not related to this BZ
Line 22: popd>/dev/null
Line 23: exit $ret
Line 24: }
Line 25:
Line 26: DEBUG () {
Line 27: if $VERBOSE; then
Line 28: printf "DEBUG: $*"
Line 29: fi
Line 30: }
this code was not changed in this patch , not related to this BZ
Line 31:
Line 32: while getopts hs:d:u:p:l:v option; do
Line 33: case $option in
Line 34: s) SERVERNAME=$OPTARG;;
Line 45: CMD="select version from schema_version where current;"
Line 46: VERSION=$(psql -w -U ${USERNAME} --pset=tuples_only=on ${DATABASE} -h
${SERVERNAME} -p ${PORT} -c "${CMD}" | sed 's/^ *//g')
Line 47: FILE=".${DATABASE}.${VERSION}.schema"
Line 48: if [[ "${VERBOSE}" = "true" ]]; then
Line 49: pg_dump -f "${FILE}" -F p -n public -s -U ${USERNAME} ${DATABASE}
-h ${SERVERNAME} -p ${PORT} -v
I see no change between this and the existent code
Line 50: else
Line 51: pg_dump -f "${FILE}" -F p -n public -s -U ${USERNAME} ${DATABASE}
-h ${SERVERNAME} -p ${PORT}
Line 52: fi
Line 53:
--
To view, visit http://gerrit.ovirt.org/19679
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d05e96f4abc66e293db23af89285b0653025537
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
