Ravi Nori has posted comments on this change.
Change subject: engine : Remove EventSubscriptionParameter
......................................................................
Patch Set 4:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EventSubscriptionCommandBase.java
Line 30: jobProperties.put("eventtype",
getEventSubscriber().getevent_up_name());
Line 31: return jobProperties;
Line 32: }
Line 33:
Line 34: public event_subscriber getEventSubscriber() {
getEventSubscriber() is called in many places, in AddEventSubscriptionCommand
and RemoveEventSubscriptionCommand. So declaring it here we can reuse.
I dont know why it is in lower case :)
Line 35: return
getParameters().<event_subscriber>getParameterValue(GenericVdcParameter.EventSubscriber);
Line 36: }
Line 37:
Line 38: /**
--
To view, visit http://gerrit.ovirt.org/20417
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e944568ac9395a141cfab3ef4d4304d1ef2d1af
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
