Mark Wu has posted comments on this change.
Change subject: Allow quoting of strings with single or double quotes
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
Besides the inline comment, I have another suggestion. The parser can support
multi-lines quoted string, but it requires each line except the last line ends
with '\'. Am I right? If yes, I think we need update Parse doc string to state
it.
....................................................
File src/cli/parser.py
Line 56: t.value = t.value.replace('\\\n', '')
If my understanding is correct, the above line should be run unconditionally.
We need handle multiple lines for string with single quotes too. Right?
--
To view, visit http://gerrit.ovirt.org/3514
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id79685788bd339e035da1e3239167bc3cef293d0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
