Juan Hernandez has posted comments on this change.
Change subject: Allow quoting of strings with single or double quotes
......................................................................
Patch Set 2: No score
(1 inline comment)
Adam, can you please apply the fix suggested by Mark?
Mark, the parser does support multiline quoted strings (so the docstring is
correct), but the way we use readline to handle input does't: we read line by
line and then parse each line separately. Changing that requires considerable
rework. Is multiline input important for you? I would greatly appreciate if you
can file a bugzilla to request/track it.
....................................................
File src/cli/parser.py
Line 56: t.value = t.value.replace('\\\n', '')
You are right, that line has to be unindented.
--
To view, visit http://gerrit.ovirt.org/3514
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id79685788bd339e035da1e3239167bc3cef293d0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
