Alon Bar-Lev has posted comments on this change.
Change subject: utils: ForwardServlet: fix generic forward to use path info
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/ForwardServlet.java
Line 113: ServletException {
Line 114: final ServletContext forwardContext =
getServletContext().getContext(targetContext);
Line 115: if (forwardContext != null) {
Line 116: String forwardUri = uri;
Line 117: if (request.getPathInfo() != null) {
not if you need to keep simple code in sync with simple documentation.
code that is readable is better than documentation as it is always consistent.
the craft is know how to write such code.
Line 118: forwardUri += request.getPathInfo();
Line 119: }
Line 120: final RequestDispatcher dispatcher =
forwardContext.getRequestDispatcher(forwardUri);
Line 121: if (dispatcher != null) {
--
To view, visit http://gerrit.ovirt.org/20784
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7307d57792fb966c8acb6ac0bdcad9302c0e3a65
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
