Vojtech Szocs has posted comments on this change.

Change subject: utils: ForwardServlet: fix generic forward to use path info
......................................................................


Patch Set 3:

(1 comment)

Just teasing :-)

....................................................
File 
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/ForwardServlet.java
Line 89:         targetContext = ServletUtils.getAsAbsoluteContext(
Line 90:             getServletContext().getContextPath(),
Line 91:             
engineLocalConfig.expandString(targetContext.replaceAll("%\\{", "\\${"))
Line 92:         );
Line 93:         uri = engineLocalConfig.expandString(uri.replaceAll("%\\{", 
"\\${"));
... because if we do that, we'll need to ........ document it :-D
Line 94:     }
Line 95: 
Line 96:     /**
Line 97:      * Forward the request to the appropriate servlet in the context 
specified in the init method. This works


-- 
To view, visit http://gerrit.ovirt.org/20784
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7307d57792fb966c8acb6ac0bdcad9302c0e3a65
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to