Lior Vernia has posted comments on this change. Change subject: frontend: remove castings for queries values ......................................................................
Patch Set 5: Is this actually a good thing, to hide the fact that we are performing an unsafe cast? I would think that the problem isn't that the code is dirty with warnings, but rather that we use unsafe casting all the time. A "proper solution" would be to make backend queries generic, paramterized by their parameter type and return type. As long as it's not generic, I think it's a good idea for developers to be aware that the casting they perform is unsafe. -- To view, visit http://gerrit.ovirt.org/18874 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I261c56dbcbdd3a620482f7c59a17398ab81e9c5c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
