Arik Hadas has posted comments on this change. Change subject: frontend: remove castings for queries values ......................................................................
Patch Set 5: lior, sure, the ideal solution will be to eliminate such castings. in the meantime, the code is full of such castings that make the code dirty because it is longer (more text) and sometimes with additional annotations to prevent 'uncheck' casting exceptions - that's what this patch tries to improve. I don't think it's a question of whether the developers aware of or not aware of those unsafe casting - they don't have any other choice currently. if we were doing 'instance of' checks before those casting then it was better to enforce the castings but since we don't do such checks and afaik we don't intend do, I think it's better to cast the query result to the required type automatically in one place. -- To view, visit http://gerrit.ovirt.org/18874 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I261c56dbcbdd3a620482f7c59a17398ab81e9c5c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
