Greg Sheremeta has posted comments on this change. Change subject: userportal, webadmin: converted docs mapping files to properties ......................................................................
Patch Set 3: Verified-1 > If we are going to generate #2 from somewhere else, couldn't we just generate > a JSON file from whatever source we have? Which would sort eliminate the need > for a servlet. I hadn't realized we wanted to generate the file when I > suggested the servlet. We effectively generate updates to an already-existing file that already has some user edits in it, basically comments. So we can't blow away the file every time -- it must live and be checked in to the project as either a properties file or a csv file. But, yes, we can also checkin the JSON copy and not bother generating it at runtime with servlet. Everyone please disregard this patch until I redo it. Thanks. -- To view, visit http://gerrit.ovirt.org/20793 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b96d005684007125d5f3940abdbec25d4cae81f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
