Einav Cohen has posted comments on this change. Change subject: userportal, webadmin: converted docs mapping files to properties ......................................................................
Patch Set 3: 1. I agree that less conversions are better in general for the application, but in this particular case I would rather be more user-friendly for the people maintaining this file, which again may be non-developers. Let's keep the .properties file. 2. I was actually thinking that we wouldn't persist the .properties files in the code-repo at all - just auto-generate them (maybe we can do it in a pre-compilation phase or similar). But in general - I am with Alon on this one - we should not maintain the .properties files (I am generally not in favor of persisting content that you can auto-generate). So we should either go with empty .properties files or with no .properties files at all in the code-repo. 4. I am not sure how this is / should be related to the branding mechanism... -- To view, visit http://gerrit.ovirt.org/20793 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b96d005684007125d5f3940abdbec25d4cae81f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
