Doron Fediuck has posted comments on this change.
Change subject: core: Clean pending memory and CPUs only during init
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Giving Roy and Omer a chance for additional comments.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
Line 210: 1,
Line 211: vm.getNumOfCpus(),
Line 212: vm.getMinAllocatedMem(),
Line 213: 0,
Line 214: 0);
Generally speaking we should not update data coming from vdsm. We can read it,
but update is wrong. So this is a real issue we had, which this change is
fixing.
Line 215: }
Line 216: return bestHost;
Line 217: }
Line 218: }
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java
Line 264: .addValue("pendingVmemSize", pendingVmemSize)
Line 265: .addValue("memCommited", memCommited)
Line 266: .addValue("vmsCoresCount", vmsCoresCount);
Line 267:
Line 268: log.debugFormat("updatePartialVdsDynamicCalc Guid:{0}
vmCount:{1} pendingCPUs:{2} pendingMem:{3}"
Roy?
Line 269: + " commitedMem:{4} commitedCpus:{5}",
Line 270: id, vmCount, pendingVcpusCount,
pendingVmemSize, memCommited, vmsCoresCount);
Line 271:
Line 272:
getCallsHandler().executeModification("UpdatePartialVdsDynamicCalc",
parameterSource);
--
To view, visit http://gerrit.ovirt.org/20172
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I84c2ba29368c0b6bc400087512d7b3a68c5c8f5c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
