Michal Skrivanek has posted comments on this change.
Change subject: core: Clean pending memory and CPUs only during init
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
Line 96: // (meaning we tried to start a VM and the engine crashed
before telling VDSM about it)
Line 97: for (VDS _vds : allVdsList) {
Line 98: boolean _saveVdsDynamic = false;
Line 99:
Line 100: if (_vds.getPendingVcpusCount() != 0 &&
!runningVmsInTransition) {
rephrase:
above runningVmsInTransition is global over all VMs, whereas here it is
considered per host? how is it related? e.g. nonresponsive host's VMs would be
consider as "in transition" affecting all the other hosts?
Line 101: _vds.setPendingVcpusCount(0);
Line 102: _saveVdsDynamic = true;
Line 103: }
Line 104:
--
To view, visit http://gerrit.ovirt.org/20172
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I84c2ba29368c0b6bc400087512d7b3a68c5c8f5c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
