Alon Bar-Lev has posted comments on this change. Change subject: packaging: gluster:Hide irrelevant fields in configuration preview during setup ......................................................................
Patch Set 5: (2 comments) Nice! Now my real question... what real benefit is to hide these settings... they are valid anyway, no? .................................................... File packaging/setup/ovirt_engine_setup/constants.py Line 47: answerfile=False, Line 48: summary=False, Line 49: description=None, Line 50: postinstallfile=False, Line 51: summary_condition=None, =lambda: True will make it easier for you, no? Line 52: ): Line 53: class decorator(classproperty): Line 54: def __init__(self, o): Line 55: super(decorator, self).__init__(o) Line 57: answerfile=answerfile, Line 58: summary=summary, Line 59: description=description, Line 60: postinstallfile=postinstallfile, Line 61: summary_condition=summary_condition comma :) Line 62: ) Line 63: return decorator Line 64: Line 65: -- To view, visit http://gerrit.ovirt.org/20955 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e4b3fffd37a62d9fc551dff178d5662d610ddd4 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Darshan N <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Aravinda VK <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
