Alon Bar-Lev has posted comments on this change.
Change subject: packaging: gluster:Hide irrelevant fields in configuration
preview during setup
......................................................................
Patch Set 5:
(3 comments)
....................................................
File packaging/setup/ovirt_engine_setup/constants.py
Line 802: description=_('NFS setup'),
Line 803: postinstallfile=True,
Line 804: summary_condition=(
Line 805: lambda env: env[ConfigEnv.APPLICATION_MODE] != 'gluster'
Line 806: ),
maybe better to condition this if the nfsConfigEnabled is true?
Line 807: )
Line 808: def NFS_CONFIG_ENABLED(self):
Line 809: return 'OVESETUP_SYSTEM/nfsConfigEnabled'
Line 810:
Line 875: summary=True,
Line 876: description=_('Application mode'),
Line 877: summary_condition=(
Line 878: lambda env: env[ConfigEnv.APPLICATION_MODE] != 'gluster'
Line 879: ),
we can always show this... you will get gluster, this is totally valid...
Line 880: )
Line 881: def APPLICATION_MODE(self):
Line 882: return 'OVESETUP_CONFIG/applicationMode'
Line 883:
Line 886: summary=True,
Line 887: description=_('Datacenter storage type'),
Line 888: summary_condition=(
Line 889: lambda env: env[ConfigEnv.APPLICATION_MODE] != 'gluster'
Line 890: ),
maybe we can put none in storage type and condition based on that?
Line 891: )
Line 892: def STORAGE_TYPE(self):
Line 893: return 'OVESETUP_CONFIG/storageType'
Line 894:
--
To view, visit http://gerrit.ovirt.org/20955
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e4b3fffd37a62d9fc551dff178d5662d610ddd4
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Darshan N <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Aravinda VK <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
