Alon Bar-Lev has posted comments on this change.
Change subject: engine : Remove dependency of IdQueryParameters from
GetRoleByIdQuery
......................................................................
Patch Set 8:
(1 comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendRoleResource.java
Line 63: protected <T> VdcQueryParametersBase getQueryParams(Class<?
extends VdcQueryParametersBase> queryParamsClass, T id) {
Line 64: return getParameters(id);
Line 65: }
Line 66:
Line 67: private <T> VdcQueryParametersBase getParameters(T id) {
OK, the problem that I see is procedural.
It will be very difficult to apply horizontal patch to all classes, leaving
this inheritance, then another horizontal patch removing it.
I think it will be much easier to merge patch per command group, but perform
the entire work of removing this parameter inheritance in favor of the new
class as a member.
Line 68: return new
VdcQueryParametersBase().addParameter(UserRolesVdcParameters.RoleId, id);
Line 69: }
Line 70:
Line 71: public class UpdateParametersProvider implements
ParametersProvider<Role, org.ovirt.engine.core.common.businessentities.Role> {
--
To view, visit http://gerrit.ovirt.org/20415
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I67fb4920f8107575dd26e173456a7edf99c3503f
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
