Alon Bar-Lev has posted comments on this change.
Change subject: engine : Remove dependency of IdQueryParameters from
GetRoleByIdQuery
......................................................................
Patch Set 8:
(1 comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendRoleResource.java
Line 63: protected <T> VdcQueryParametersBase getQueryParams(Class<?
extends VdcQueryParametersBase> queryParamsClass, T id) {
Line 64: return getParameters(id);
Line 65: }
Line 66:
Line 67: private <T> VdcQueryParametersBase getParameters(T id) {
It is not that I am insisting... it just people will be prepare to review and
test the entire engine once... so we need to reach from point A to point B and
have no more significant changes we know at that time.
The noise we create to reach A->B->C will force people to review partial
solution, validate partial solution, then do this again (and maybe again), and
we may lose cooperation.
Why not put all as parameters in the map?
Line 68: return new
VdcQueryParametersBase().addParameter(UserRolesVdcParameters.RoleId, id);
Line 69: }
Line 70:
Line 71: public class UpdateParametersProvider implements
ParametersProvider<Role, org.ovirt.engine.core.common.businessentities.Role> {
--
To view, visit http://gerrit.ovirt.org/20415
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I67fb4920f8107575dd26e173456a7edf99c3503f
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
