Lior Vernia has posted comments on this change.
Change subject: webadmin : Removing instead of hiding virt-related fields in
the host->general sub-tab
......................................................................
Patch Set 14:
(1 comment)
Another comment on the patch, and a general question as well: I noticed that in
Gluster only mode, the first column would have 3 rows, the second 5, and the
third 3. Doesn't it look kinda weird?
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralView.java
Line 136:
Line 137: formBuilder.addFormItem(new
FormItem(constants.osVersionHostGeneral(), oS, ++rowCount, 0));
Line 138: formBuilder.addFormItem(new
FormItem(constants.kernelVersionHostGeneral(), kernelVersion, ++rowCount, 0));
Line 139: if (virtSupported) {
Line 140: formBuilder.addFormItem(new
FormItem(constants.kvmVersionHostGeneral(), kvmVersion, ++rowCount, 0,
virtSupported));
Also, once these happen inside the if clause, then there's no reason to pass
virtSupported to the FormItem constructor.
Line 141: formBuilder.addFormItem(new
FormItem(constants.libvirtVersionHostGeneral(), libvirtVersion, ++rowCount, 0,
virtSupported));
Line 142: }
Line 143: formBuilder.addFormItem(new
FormItem(constants.vdsmVersionHostGeneral(), vdsmVersion, ++rowCount, 0));
Line 144: if (virtSupported) {
--
To view, visit http://gerrit.ovirt.org/20603
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8023616e95d2b52a0c4f813037df1e7f10e6083f
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: anmolbabu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
